Skip to content

update subm#217

Merged
liunyl merged 2 commits intoeloq-10.6.10from
parallel_putall
Jan 21, 2026
Merged

update subm#217
liunyl merged 2 commits intoeloq-10.6.10from
parallel_putall

Conversation

@liunyl
Copy link
Contributor

@liunyl liunyl commented Jan 20, 2026

Note

Adds two new store tuning parameters to DS/concourse and MySQL test configs.

  • Introduces eloq_store_max_concurrent_writes=0 and eloq_store_pages_per_file_shift=1 in concourse/scripts/*.ini|*.cnf and storage/eloq/mysql-test/**/data_substrate*.cnf
  • No code changes; only config updates affecting write concurrency and page sizing behavior

Written by Cursor Bugbot for commit eb5b954. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Chores

    • Updated a submodule pointer; no functional changes visible to users.
  • Configuration

    • Added two new store configuration options across test/storage configs to control max concurrent writes and pages-per-file shift, which may affect storage write concurrency and paging behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Walkthrough

Submodule pointer for data_substrate updated; multiple config files had two new [store] keys added: eloq_store_max_concurrent_writes=0 and eloq_store_pages_per_file_shift=1. No code/control-flow changes detected.

Changes

Cohort / File(s) Summary
Submodule Reference Update
data_substrate
Updated submodule commit pointer from 0264689f66177cc96140b8fd7546075c5bce9255 to e6d2d15f2234777ed9c4a09942dcbc5202f87bf3.
Config Additions — storage CNF
storage/eloq/mysql-test/mono_basic/data_substrate.cnf, storage/eloq/mysql-test/mono_main/data_substrate.cnf, storage/eloq/mysql-test/mono_multi/data_substrate1.cnf, storage/eloq/mysql-test/mono_multi/data_substrate2.cnf, storage/eloq/mysql-test/mono_multi/data_substrate3.cnf
Added [store] entries: eloq_store_max_concurrent_writes=0 and eloq_store_pages_per_file_shift=1. No deletions or other edits.
Config Additions — CI / bootstrap scripts
concourse/scripts/dss_server.ini, concourse/scripts/mtr_bootstrap_ds.cnf, concourse/scripts/mtr_multi_bootstrap_ds.cnf
Added the same two [store] entries (eloq_store_max_concurrent_writes=0, eloq_store_pages_per_file_shift=1).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • githubzilla
  • lzxddz

Poem

🐰 I hopped through configs, left two tiny seeds,
A pointer nudged forward, no frantic deeds.
Quiet keys planted where store fields grow,
A soft little patch in the moonlight's glow. 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'update subm' is vague and does not clearly convey what the pull request changes; it appears to be an incomplete or truncated description. Revise the title to be more descriptive, such as 'Add store tuning parameters to ELOQ test configs' or similar, clearly indicating the main purpose of the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch parallel_putall

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@data_substrate`:
- Line 1: The submodule in data_substrate points to a non-existent commit
e6d2d15f2234777ed9c4a09942dcbc5202f87bf3 for the remote
https://github.com/eloqdata/tx_service.git; either push the missing commit to
that remote (ensure branch parallel_putall contains e6d2d15f...) or update the
submodule pointer to a valid existing commit (e.g., 6b90900a28) and commit that
change. Locate the submodule entry referencing the tx_service repo, verify the
intended commit hash locally and on the remote, then either push the missing
commit or change the submodule ref to the correct hash and commit the updated
submodule reference so CI can fetch it.

@liunyl liunyl merged commit d23eb4b into eloq-10.6.10 Jan 21, 2026
4 checks passed
@liunyl liunyl deleted the parallel_putall branch January 21, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants